Skip to content

test(install): preserve duplicate library diagnostics #16022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alizter wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −0
Open

test(install): preserve duplicate library diagnostics #16022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/blackbox-tests/test-cases/lib-collision/lib-collision-public-same-public-name.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,19 @@ different folders.
> (public_name bar.foo))
> EOF

The install-entry consumer preserves the usual diagnostic without relying on
another target to force scope validation first.

$ dune build @install
File "b/dune", lines 1-3, characters 0-44:
1 | (library
2 | (name bar)
3 | (public_name bar.foo))
Error: Public library bar.foo is defined twice:
- a/dune:1
- b/dune:1
[1]

Without any consumers of the libraries

$ dune build
Expand Down
Loading