Skip to content

test(package-deps): snapshot template artifact overrides #16027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alizter wants to merge 1 commit into
base: main
Choose a base branch
from
+40 −0
Open

test(package-deps): snapshot template artifact overrides #16027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/blackbox-tests/test-cases/package-materialization/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
installed-package
no-transitive-through-targets
ocamlfind
template-artifacts
virtual-without-default)
(deps %{bin:ocamlfind}))
39 changes: 39 additions & 0 deletions test/blackbox-tests/test-cases/package-materialization/template-artifacts.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
A META file template can override path-bearing variables without changing the
library graph. Retaining such a rule while materializing only Dune-selected
artifacts produces dangling support metadata.

$ make_dune_project 3.24
$ cat >>dune-project <<'EOF'
> (package (name artifact-support))
> EOF

$ mkdir support
$ cat >support/dune <<'EOF'
> (library
> (name artifact_support)
> (public_name artifact-support))
> EOF
$ echo 'let value = 42' >support/artifact_support.ml

$ cat >META.artifact-support.template <<'EOF'
> # DUNE_GEN
> archive(byte,custom) = "missing.cma"
> EOF

$ cat >dune <<'EOF'
> (rule
> (target result)
> (deps (package artifact-support))
> (action
> (with-stdout-to %{target}
> (run %{bin:ocamlfind} query -predicates byte,custom -format "%d/%A" artifact-support))))
> EOF

The installed META currently retains the conditional archive override even
though that artifact is not part of the package layout.

$ dune build result
$ cat _build/default/result | censor
$PWD/_build/install/default/.packages/$DIGEST/lib/artifact-support/missing.cma
$ test -d "$(cat _build/default/result)"
[1]
Loading