Skip to content

test(package-deps): snapshot instrumentation metadata dependencies #16029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alizter wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −0
Open

test(package-deps): snapshot instrumentation metadata dependencies #16029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions test/blackbox-tests/test-cases/package-materialization/instrumentation-dependencies.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
Instrumentation backend metadata names a PPX library that is not an ordinary
library requirement. The scoped layout must track the referenced library and
its metadata.

$ make_dune_project 3.24
$ cat >>dune-project <<'EOF'
> (package (name instrumentation-root))
> (package (name instrumentation-ppx))
> EOF

$ mkdir backend ppx
$ cat >backend/dune <<'EOF'
> (library
> (name backend)
> (public_name instrumentation-root)
> (modules ())
> (instrumentation.backend
> (ppx instrumentation-ppx)))
> EOF

$ cat >ppx/dune <<'EOF'
> (library
> (name ppx)
> (public_name instrumentation-ppx)
> (kind ppx_rewriter)
> (modules ()))
> EOF

$ cat >dune <<'EOF'
> (rule
> (target marker)
> (deps (package instrumentation-root))
> (action (write-file %{target} "ok")))
> EOF

The PPX package's metadata is not currently a dependency of the action.

$ dune rules --format=json _build/default/marker |
> jq_dune '.[] | ruleDepFilePaths' |
> censor |
> grep 'lib/instrumentation-ppx/dune-package'
[1]
Loading