test(rocq): expose missing native plugin layout entries - #16051
Merged
Conversation
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
added a commit
that referenced
this pull request
Aug 20, 2026
## Description Materialize `Section.Libexec` entries in the package-scoped library layout used while compiling Rocq theories. Dune classifies native OCaml plugins as `Libexec`, while the opam-style layout places both `Lib` and `Libexec` under `lib/<package>`. Root sections remain excluded so Rocq theory outputs do not introduce same-package build cycles. This updates the green regression snapshot from #16051 to include the native plugin. ## Validation In addition to the targeted Rocq cram test, I reproduced #16048 with Rocq itself checked out in the same workspace. With this patch, Dune built the workspace Rocq and the consuming theory successfully, with the `rocq-runtime` native plugin links present in the scoped package layout. ## Related Issue and Motivation Fixes #16048.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend the Rocq plugin META cram test to inspect native plugin entries in the package-scoped layout created before
rocqdep.The current expectation deliberately snapshots the bug: the META file is present while the
.cmxsis absent, keeping the regression commit green. A follow-up fix will update the prose and expected output.Related Issue and Motivation
Part of #16048. Rocq can discover a plugin META file in the scoped layout while the corresponding native plugin has not been materialized.