Open
Conversation
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
Signed-off-by: Sacha Ayoun <sachaayoun@gmail.com>
|
@shindere and @thierry-martinez, is there any chance this gets merged at some point? |
Author
|
Last time we interacted, I think @shindere decided to see if stdcompat could be updated regularly in sync with the main compiler, instead of removing support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyml uses Stdcompat for 2 functions. Stdcompat is a heavy dependency that often makes repository past-proof at the cost of not making them future-proof. In particular, Pyml is currently incompatible with ocaml 5.0+
Without Stdcompat, pyml was naturally compatible with ocaml 4.14+ and beyond. Because it was not much work, I added compatibility by adding these two functions by hand. Pyml is still compatible with 4.08 and above after this PR.