Makefile: recompile CSS when SASS sources change#6
Open
balat wants to merge 1 commit into
Open
Conversation
The $(LOCAL_CSS) rule listed only the npm and external-CSS prerequisites, never the SASS sources, so editing the main stylesheet or a partial under sass/ did not mark the compiled CSS out of date — make kept serving the stale CSS until it was deleted by hand. Add $(SASS_SRC) and the sass/ (+ sass/lib/) partials as prerequisites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as ocsigen/ocsigen-start#707, for this template.
The
$(LOCAL_CSS)rule lists only the npm and external-CSS prerequisites, never the SASS sources, so editing the main stylesheet or a partial undersass/does not mark the compiled CSS out of date:makekeeps serving the stale CSS until it is deleted by hand. Fresh/clean builds are unaffected (the CSS is built once) — this only bites incremental.scssedits.Fix: list the SASS sources as prerequisites of
$(LOCAL_CSS):The wildcards expand to nothing when those directories are absent, so projects without partials are unaffected.