Refactor hardcore FPGA bits application logic

[J-DSilva]

When playing on the NES core I found that even though hardcore mode was disabled the option to load save states was disabled. This was due to the setting in achievements.cfg being ignored and Main_MiSTer always sending set_hardcore(1). This fix introduces some logic to properly set the flag so the console core will behave properly.

[J-DSilva]

Full disclosure: I used AI to find and fix this issue. I did compile and test the fix with both hardcore=0 and 1 and found no issues.

[odelot]

Sorry for the late reply, I missed the PR notification. I will analyse the PR this weekend and send you a proper answer. Thanks

[odelot]

I think the latest version already fixed this issue.

I have tested with

hardcore=0
force_hardcore=0

and could save and restore state

Can you confirm this behaivor with the latest version? than we can close the issue.

Thank you very much to report and try to help

[J-DSilva]

I did a quick test with 1.3.0 and the problem reappeared for me using the RA_NES 1.4 core. The Restore State option in the menu is greyed out, and the hot keys do not work. Saving states appears to be fine. This is with:

hardcore=0
force_hardcore=0

I switched back to my build and restore states is working fine again.