don't wait for !is_busy in closed loop control#37
Merged
Conversation
This addresses a firmware change in fw v0.6.11, in which requested_state during CLOSED_LOOP_CONTROL is newly reported as BUSY. Previously, when issuing a `request_axis_state` service call with `CLOSED_LOOP_CONTROL`, the node would wait for the axis to leave the BUSY state before returning. Since fw v0.6.11, this meant that the call would never return when entering CLOSED_LOOP_CONTROL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses a firmware change in fw v0.6.11, in which requested_state during CLOSED_LOOP_CONTROL is newly reported as BUSY.
Previously, when issuing a
request_axis_stateservice call withCLOSED_LOOP_CONTROL, the node would wait for the axis to leave the BUSY state before returning. Since fw v0.6.11, this meant that the call would never return when entering CLOSED_LOOP_CONTROL.