Add icons to the Settings and Security menus - #158
Open
sandman21vs wants to merge 2 commits into
Open
Conversation
fb1ad7a closed the same gap on Back Up: the menus reached from the login screen draw an icon beside every entry, so Settings — reached from an entry that has one itself — looked unfinished once opened, its four rows plain text against icons everywhere else. Every glyph here already ships: ICON_KEY from icons.h for the PIN that unlocks the device, and three LVGL built-ins the Montserrat fonts already carry, so no glyph is baked and no asset changes. Brightness and Screensaver take the open and closed eye — the screen lit and the screen asleep — and Firmware Update the download arrow it shares with every installer.
The parent Settings menu now draws an icon on every row, so its Security submenu was the next plain-text list: opening the one entry that promises icons landed on two rows without them. Both glyphs are LVGL built-ins the Montserrat fonts already carry, so no glyph is baked and no asset changes. The PIN row takes the keyboard, the icon the manual-entry pages already use for something you key in, and it is the same on both branches because Set Up PIN and PIN Settings are one concept at two stages. Session Timeout takes the bell: the symbol set has no clock or hourglass, and an alarm is the nearest thing in it to time running out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every menu reached from the login screen puts an icon next to each entry —
except Settings, and the Security page inside it. You tap a row that has an
icon and land on a list that doesn't.
This gives those entries icons, all from glyphs that already ship: ICON_KEY
plus four LVGL built-ins the Montserrat fonts already carry. Nothing is baked,
no asset changes, 22 lines in two files. Same approach as fb1ad7a on Back Up.
The one worth bikeshedding is Session Timeout: there's no clock or hourglass
in the symbol set, so it got the bell. Happy to swap it.
Tested on a Waveshare 4.3.