Remove explicit dependence on psqt head in nnuecomplexity - #6631
Open
sscg13 wants to merge 5 commits into
Open
Conversation
bench: 2684075
bench: 2864296
Member
|
Goat |
Member
|
one disadvantage of this patch is that the psqt + positional are now combined with prefactors in the network evaluation, so that eval won't directly match the one we get in nnue-pytorch. Making it a bit more difficult to check. I wonder if this term could be directly included in the network training? |
Contributor
Author
|
I do think it is odd that using different weightings than in the trainer gains elo, it is something to investigate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also will make it simpler to test simplifications of psqt head in the future.
Passed non-regression STC:
LLR: 2.93 (-2.94,2.94) <-1.75,0.25>
Total: 97024 W: 25319 L: 25165 D: 46540
Ptnml(0-2): 346, 11411, 24820, 11613, 322
https://tests.stockfishchess.org/tests/view/6997c023742628af3a802bb3
Passed non-regression LTC:
LLR: 2.97 (-2.94,2.94) <-1.75,0.25>
Total: 108384 W: 27844 L: 27711 D: 52829
Ptnml(0-2): 59, 11809, 30326, 11936, 62
https://tests.stockfishchess.org/tests/view/69998392403ae8f29a7fc8bc
bench: 2864296
Co-authored-by: Joost Vandevondele Joost.VandeVondele@gmail.com