Skip to content

Avoid exceptions in UCI spin option validation #6738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luckysolanki902 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid exceptions in UCI spin option validation #6738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/ucioption.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include <algorithm>
#include <cassert>
#include <cerrno>
#include <cctype>
#include <cstdlib>
#include <iostream>
Expand Down Expand Up @@ -153,10 +154,24 @@ Option& Option::operator=(const std::string& v) {
assert(!type.empty());

if ((type != "button" && type != "string" && v.empty())
|| (type == "check" && v != "true" && v != "false")
|| (type == "spin" && (std::stoi(v) < min || std::stoi(v) > max)))
|| (type == "check" && v != "true" && v != "false"))
return *this;

// For spin options, reject values that don't parse as a full int or fall
// outside [min, max]. std::strtol is used instead of std::stoi because the
// codebase is compiled with -fno-exceptions, so throwing on malformed UCI
// input would terminate the engine.
if (type == "spin")
{
errno = 0;
char* end = nullptr;
const char* begin = v.c_str();
const long parsed = std::strtol(begin, &end, 10);

if (begin == end || *end != '\0' || errno == ERANGE || parsed < min || parsed > max)
return *this;
}

if (type == "combo")
{
OptionsMap comboMap; // To have case insensitive compare
Expand Down
Loading