Skip to content

NNUE: Bound network description size #6904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
overcharged-coder wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −3
Open

NNUE: Bound network description size #6904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/nnue/network.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ namespace Stockfish::Eval::NNUE {

namespace Detail {

constexpr u32 MaxDescriptionSize = 1024 * 1024;

// Read evaluation function parameters
template<typename T>
bool read_parameters(std::istream& stream, T& reference) {
Expand Down Expand Up @@ -306,20 +308,29 @@ bool Network::read_header(std::istream& stream, u32* hashValue, std::string* des
version = read_little_endian<u32>(stream);
*hashValue = read_little_endian<u32>(stream);
size = read_little_endian<u32>(stream);
if (!stream || version != Version)
if (!stream || version != Version || size > Detail::MaxDescriptionSize)
return false;

desc->resize(size);
stream.read(&(*desc)[0], size);

if (size)
stream.read(desc->data(), size);
return !stream.fail();
}


// Write network header
bool Network::write_header(std::ostream& stream, u32 hashValue, const std::string& desc) const {
if (desc.size() > Detail::MaxDescriptionSize)
return false;

write_little_endian<u32>(stream, Version);
write_little_endian<u32>(stream, hashValue);
write_little_endian<u32>(stream, u32(desc.size()));
stream.write(&desc[0], desc.size());

if (!desc.empty())
stream.write(desc.data(), desc.size());

return !stream.fail();
}

Expand Down
Loading