Some search comment tweaks (grammar, redundancy, clarification)

[dubslow]

(This can be squashed into the bigger cleanup commit)

[github-actions]

clang-format 20 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/plucky/clang-format-20.

(execution 28502694626 / attempt 1)

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 144235d2-29a8-406d-a671-1cc8ece5ee38

📥 Commits

Reviewing files that changed from the base of the PR and between 76de928 and 6d6e48e.

📒 Files selected for processing (3)

• src/search.cpp
• src/search.h
• src/thread.cpp

🚧 Files skipped from review as they are similar to previous changes (3)

• src/thread.cpp
• src/search.h
• src/search.cpp

---

📝 Walkthrough

Walkthrough

This pull request changes Search::RootMove score-state bookkeeping from bound flags to inexact flags, and updates root rollback, PV reporting, and decisive-thread selection to use the new helpers and fields. It also renumbers and reformats internal step comments in search and qsearch, including final assertion formatting. No exported or public entity declarations were added.

Changes

Cohort / File(s)	Summary
RootMove inexact-flag migration and search comments	src/search.h, src/search.cpp, src/thread.cpp
RootMove flag API	Replaces bound-flag helpers and fields with inexact-flag helpers and fields; makes operator< constexpr
RootMove flag usage	Updates rollback, PV output, and thread selection to use inexact flags
Search step comments	Renumbers internal step comments in search and qsearch, with assertion formatting updates

Sequence Diagram(s)

sequenceDiagram
  participant SearchWorker
  participant SearchManager
  participant ThreadPool
  participant RootMove
  SearchWorker->>RootMove: set inexactLower / inexactUpper during rollback
  SearchManager->>RootMove: read is_inexact() for PV reliability and bound output
  ThreadPool->>RootMove: read is_inexact() for decisive-move filtering

Loading

Suggested labels: refactor, search

Suggested reviewers: None identified.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

clang-format 20 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/plucky/clang-format-20.

(execution 28544756141 / attempt 1)

[dubslow]

I've added a second commit unrelated to the first. Like the first, it is completely optional and (if accepted) can (should?) be squashed into the final cleanup commit

[github-actions]

clang-format 20 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/plucky/clang-format-20.

(execution 28544839072 / attempt 1)

[MinetaS]

Looks mostly ok (talking about the first commit only) but

• the last steps in search() and qsearch() look redundant
• I'm really against adding more comments especially at singular extensions, in fact the existing comment already feels excessive
• I personally don't prefer having explicit "step 0"

[github-actions]

clang-format 20 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/questing/clang-format-20.
An easier way to install it might be through https://apt.llvm.org/#llvmsh.

(execution 30415064420 / attempt 1)

[dubslow]

Rebased, addressed feedback