Remove Redundant Transposition Table Validity Check in Step 12 - #6986
Closed
FauziAkram wants to merge 1 commit into
Closed
Remove Redundant Transposition Table Validity Check in Step 12#6986FauziAkram wants to merge 1 commit into
FauziAkram wants to merge 1 commit into
Conversation
No functional change
Contributor
|
Haven't we had this discussion already in a still-open PR? Threading means sometimes the tt entries we read can be corrupted/inconsistent, so we cannot rely on one part of the However I'm not sure how accurate the previous paragraph is after the relaxed atomics change. Do we still have tt races on typical stockfish hardware? |
Member
Yes The consistency of two members of the same TTEntry can never be guaranteed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check is completely redundant because the condition already verifies ttData.bound & BOUND_LOWER, isn't it?
A lower-bound entry is only recorded when a valid transposition table value has been successfully retrieved during a transposition table hit.
No functional change