Add test for partially numeric spin option - #7008
Open
jdeguzman11 wants to merge 1 commit into
Open
Conversation
Member
|
I'm not so sure we want to test this works. This is largely undefined behavior / invalid input? |
Author
That makes sense. My thought was to add regression coverage for the stricter numeric parsing added recently, specifically to ensure partially numeric values like 12abc continue to be rejected rather than partially parsed. But I agree that if malformed setoption input is considered outside the behavior Stockfish intends to guarantee, then this test may be too specific. Happy to drop or adjust it if there’s a more appropriate edge case to cover. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression coverage for partially numeric spin option values such as
12abc.The existing invalid option tests cover non-numeric, negative, and out-of-range values, but not values that begin with valid digits and contain trailing non-numeric characters.
Validation:
python3 -m py_compile tests/instrumented.pypython3 tests/instrumented.py src/stockfishNo functional change.