[RFC] remove non-VECTOR code path in nnue_accumulator.cpp - #7014
Draft
ces42 wants to merge 3 commits into
Draft
Conversation
|
clang-format 20 needs to be run on this PR. (execution 30462432105 / attempt 1) |
ces42
marked this pull request as draft
July 29, 2026 14:45
Contributor
Author
|
(this is currently broken on RISC-V) |
Member
|
I think this is good, the non-vector impls should just be there for correctness purposes |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a PR on top of #7013.
This might be a slight slowdown for binaries without vectorization. E.g. x86-32 running on Redwood Cove:
Should result in exactly the same code after pre-processing for any uarch that has
defined(VECTOR) || defined(USE_RVV).No functional change