Simplify shm_unix SharedMemoryRegistry - #7030
Open
niklasf wants to merge 1 commit into
Open
Conversation
The SharedMemoryRegistry now directly keeps a list of socket paths to unlink in the atexit handler. Before there were two minor issues: - Unsynchronized access to some SharedMemory members between open() and close() called from the atexit handler, though of course only when we were about to exit anyway. - Moved from socket_path_ not nescessarily emptied and would then be unlinked, though i don't think any C++ implementation actually does that. Also now just one atomic linked list away from a signal-safe cleanup_at_exit(), but one step further from a shared memory implementation that needs more general global cleanup work.
Member
|
The atomic linked list would be really nice... but it's not clear how to do concurrent removal. Sopel brought up the idea of just having a bounded static vector, which could work well, but maybe incompatible with our future libfish ambitions |
Contributor
Author
|
Maybe easier if remove/add still takes a mutex, while trying to keep iteration without a mutex safe. Not sure. |
Member
|
right, well one approach I had was to keep the mutex, and atomically exchange a pointer to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SharedMemoryRegistry now directly keeps a list of socket paths to unlink in the atexit handler.
Before, there were two minor issues:
Also now just one atomic linked list away from a signal-safe cleanup_at_exit(), but one step further from a shared memory implementation that needs more general global cleanup work.
No functional change