Auto-enable TLS for access nodes on port 443#2317
Open
peterargue wants to merge 1 commit intomasterfrom
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransportCredentialForHostandGRPCDialOptionForHosthelpers ininternal/util/for consistent behavior across all gRPC connection pointsNewGrpcGateway,NewBaseClient, andgrpc.NewClientcall sites to use the new helpersthis can be used when connecting to QuickNode, or other ANs with a standard CA signed certificate
Context
Access nodes behind TLS-terminating proxies (e.g. on port 443) require proper CA-based certificate verification. Previously, all non-key-authenticated connections used insecure credentials regardless of port. This change makes the CLI automatically do the right thing when connecting to port 443 endpoints.
Non-443 ports (emulator on 3569, mainnet/testnet on 9000, etc.) retain existing insecure transport behavior.
Test plan
--hostflag with:443suffix enables TLS automatically