Bump cockroachdb/swiss for Go 1.26 compatibility#8494
Bump cockroachdb/swiss for Go 1.26 compatibility#8494dom-nie wants to merge 2 commits intoonflow:masterfrom
Conversation
📝 WalkthroughWalkthroughBumped the indirect dependency Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
insecure/go.mod (1)
312-312:⚠️ Potential issue | 🟠 MajorBump
go.opentelemetry.io/otel/sdkto v1.40.0 to address HIGH severity PATH hijacking vulnerability (GO-2026-4394/GHSA-9h8m-3fm2-qjrq).Version v1.39.0 remains vulnerable to this code execution risk. Patched version v1.40.0 is available.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@insecure/go.mod` at line 312, Update the vulnerable dependency go.opentelemetry.io/otel/sdk from v1.39.0 to the patched v1.40.0 in the go.mod entry for go.opentelemetry.io/otel/sdk; after updating the version string, run go get go.opentelemetry.io/otel/sdk@v1.40.0 (or go get ./... as appropriate) and then go mod tidy to reconcile go.sum and ensure the new version is recorded and vendored if used. Ensure the module line referencing go.opentelemetry.io/otel/sdk is the only change and verify builds/tests pass.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@insecure/go.mod`:
- Line 312: Update the vulnerable dependency go.opentelemetry.io/otel/sdk from
v1.39.0 to the patched v1.40.0 in the go.mod entry for
go.opentelemetry.io/otel/sdk; after updating the version string, run go get
go.opentelemetry.io/otel/sdk@v1.40.0 (or go get ./... as appropriate) and then
go mod tidy to reconcile go.sum and ensure the new version is recorded and
vendored if used. Ensure the module line referencing
go.opentelemetry.io/otel/sdk is the only change and verify builds/tests pass.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d90c90e1-1fef-471e-804a-31a234170a1e
⛔ Files ignored due to path filters (3)
go.sumis excluded by!**/*.suminsecure/go.sumis excluded by!**/*.sumintegration/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
go.modinsecure/go.modintegration/go.mod
3f46f12 to
f8990db
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
insecure/go.mod (1)
312-312:⚠️ Potential issue | 🟠 MajorUpgrade OpenTelemetry SDK to patch PATH hijacking vulnerability.
The dependency
go.opentelemetry.io/otel/sdk v1.39.0contains a HIGH severity vulnerability (GHSA-9h8m-3fm2-qjrq / CVE-2026-24051) in the resource detection code that allows arbitrary code execution via PATH hijacking on macOS/Darwin systems. Upgrade tov1.40.0or later to resolve.While unrelated to this PR's changes, this is a separate security issue that should be addressed.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@insecure/go.mod` at line 312, The go.opentelemetry.io/otel/sdk dependency pinned to v1.39.0 is vulnerable; update the module requirement to v1.40.0 or later (replace the line referencing go.opentelemetry.io/otel/sdk v1.39.0 in go.mod), then run the Go tooling (e.g., go get go.opentelemetry.io/otel/sdk@v1.40.0 and go mod tidy) to refresh go.sum and ensure the updated version is vendored/locked across the build; verify no other constraints pin the older version.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@insecure/go.mod`:
- Line 312: The go.opentelemetry.io/otel/sdk dependency pinned to v1.39.0 is
vulnerable; update the module requirement to v1.40.0 or later (replace the line
referencing go.opentelemetry.io/otel/sdk v1.39.0 in go.mod), then run the Go
tooling (e.g., go get go.opentelemetry.io/otel/sdk@v1.40.0 and go mod tidy) to
refresh go.sum and ensure the updated version is vendored/locked across the
build; verify no other constraints pin the older version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2a75638b-06d5-4968-a3c8-b7ba0e4aa6c0
⛔ Files ignored due to path filters (3)
go.sumis excluded by!**/*.suminsecure/go.sumis excluded by!**/*.sumintegration/go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
go.modinsecure/go.modintegration/go.mod
✅ Files skipped from review due to trivial changes (1)
- integration/go.mod
🚧 Files skipped from review as they are similar to previous changes (1)
- go.mod
Closes: #8493
Summary
cockroachdb/swissfromv0.0.0-20250624142022-d6e517c1d961tov0.0.0-20251224182025-b0f6560f979bacross all three modules (root, insecure, integration)//go:linknameto access Go runtime internals (hashFn,getRuntimeHasher,fastrand64) that were removed in Go 1.26, causing build failuresSummary by CodeRabbit