Polish header bar logos: simplify SVG, use currentColor for theme support#3092
Open
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Open
Polish header bar logos: simplify SVG, use currentColor for theme support#3092devin-ai-integration[bot] wants to merge 2 commits intomainfrom
devin-ai-integration[bot] wants to merge 2 commits intomainfrom
Conversation
…port - OnlookLogo: Remove complex multi-layer mask/clip approach, use clean circle stroke + clipped mark path with currentColor - OnlookTextLogo: Replace hardcoded black fill/stroke with currentColor, remove dark:invert hack, add explicit viewBox - Remove all redundant inline style attributes from both logos Co-Authored-By: joel <joel@onlook.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Co-Authored-By: joel <joel@onlook.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleans up the
OnlookLogoandOnlookTextLogoSVG icons inpackages/uito be simpler and theme-adaptive.OnlookLogo (circular icon):
#F7F7F7/#202123) with a clean circle stroke + single clipped mark pathcurrentColorso the logo adapts to light/dark themes nativelyOnlookIcon(added separately on main)OnlookTextLogo (wordmark):
blackstroke/fill withcurrentColordark:invertfrom className (no longer needed withcurrentColor)styleattributes that duplicated thefill/strokeattributesRelated Issues
None
Type of Change
Testing
dark:invertremoval is safe —OnlookTextLogonow relies oncurrentColorinheriting a visible text color in both light and dark themes. Confirm all usage sites (editor TopBar, projects TopBar, sign-in, requirements) set appropriate text color on parent elements. If any parent has no explicit text color in dark mode, the wordmark could render black-on-dark.onlook-logo-clipis hardcoded. If multipleOnlookLogoinstances render on the same page, the IDs would collide. (Pre-existing issue with the old IDs too, but worth noting.)Additional Notes
The Chromatic CI check fails due to a pre-existing lockfile mismatch (
--frozen-lockfile), unrelated to these changes.Link to Devin session: https://app.devin.ai/sessions/525188d41b1f4c64b17e189e76bed687