feat: make config.trigger optional as it is not really required#113
Open
yeliex wants to merge 1 commit intoonlyhom:masterfrom
Open
feat: make config.trigger optional as it is not really required#113yeliex wants to merge 1 commit intoonlyhom:masterfrom
config.trigger optional as it is not really required#113yeliex wants to merge 1 commit intoonlyhom:masterfrom
Conversation
yeliex
changed the title
config.trigger optional as it is not really requiredconfig.trigger optional as it is not really required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently, the trigger element is only required to set selected value and for auto open event bind; as we can call
.open()manually, it should be optional