Exodus-compatible Ed25519 import and on-chain transaction signing#317
Open
roccomuso wants to merge 3 commits into
Open
Exodus-compatible Ed25519 import and on-chain transaction signing#317roccomuso wants to merge 3 commits into
roccomuso wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for importing 64-character hex private keys produced by wallets that use BIP32 + Ed25519 on the same Ontology path as OWallet (e.g. Exodus), and fixes Ed25519 transaction signing so signatures match what the network verifies.
Problem
Import: Default import treats 64-hex keys as ECDSA P-256, so addresses did not match Exodus even when the derivation path matched on paper.
Decrypt: Encrypted keystores for EDDSA / Ed25519 must be wrapped with algorithm + parameters from the saved JSON; using only the ciphertext string breaks decryption.
Send: After import, txs failed with “transaction verify signature fail” because ontology-ts-sdk applied an extra SHA512 step before Ed25519 signing, while the chain verifies Ed25519 over the raw transaction hash (getSignContent() / double-SHA256 payload).
Test