-
Notifications
You must be signed in to change notification settings - Fork 9
feat(events): add LavaLyrics events #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Vitek14
wants to merge
16
commits into
ooliver1:master
Choose a base branch
from
Vitek14:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f25887c
Added Lyrics events to dispatch_event function in player.py
Vitek14 3cd5888
Added LyricsEvents to events.py
Vitek14 08908b6
Added 'subscribe_to_lyrics' command in node.py to watch lyrics updates
Vitek14 f66e6bb
style: auto fixes from pre-commit hooks
pre-commit-ci[bot] c96a271
Added common LavaLyrics Types: https://github.com/topi314/LavaLyrics?…
Vitek14 d9f451e
Added event types to incoming.py
Vitek14 26d28f1
Added event names to __all__ var
Vitek14 3f96106
Added LyricsObject to common.py __all__ var
Vitek14 80d1e7e
Added typing things to events.py(Typed dict instead of dict as reques…
Vitek14 d4824e7
Added http routes: unsubscribe_from_lyrics, get_playing_lyrics, get_l…
Vitek14 1d6d3c7
Merge remote-tracking branch 'origin/master'
Vitek14 53b3328
style: auto fixes from pre-commit hooks
pre-commit-ci[bot] 8187b84
Fixed ruff errors
Vitek14 1ec7edc
Merge remote-tracking branch 'origin/master'
Vitek14 17ccebe
style: auto fixes from pre-commit hooks
pre-commit-ci[bot] db2f4ba
Moved PluginData import to TYPE_CHEKING if statement cause it throw c…
Vitek14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe a better solution is to continue to use the
playerin both of these events, as it is available innode.py's event handling, and also contains this guild id if required. Users can use that player to add any data they need - say to return the error to the user more efficiently.