-
Notifications
You must be signed in to change notification settings - Fork 99
✨ Helm Chart for VideoQnA Application #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 10 commits
131861f
7cd488a
1f121e9
418edb7
24b4e3f
880e406
0110b85
56afc63
1a5f762
5fbfe85
3bb015d
a29691b
e8f58bb
a8cbdbf
63bf7f6
cf4360f
2d02cf9
d03a52f
1e5eea1
6e832ea
fc17e30
5ee3dc0
ea180a5
ef695c8
7be67a1
3cf4f29
0e37189
d13bdcb
c932c31
a993f1a
773922e
4bd8b04
91f96ec
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,11 +41,28 @@ spec: | |
| {{- toYaml .Values.securityContext | nindent 12 }} | ||
| image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" | ||
| imagePullPolicy: {{ .Values.image.pullPolicy }} | ||
| {{- if .Values.entryCommand }} | ||
| command: {{ .Values.entryCommand }} | ||
| {{- end }} | ||
| {{- if .Values.extraArgs }} | ||
| args: | ||
| {{- range .Values.extraArgs }} | ||
| - {{ . | quote }} | ||
| {{- end }} | ||
| {{- end }} | ||
| ports: | ||
| - name: data-prep | ||
| containerPort: {{ .Values.port }} | ||
| containerPort: {{ .Values.service.containerPort }} | ||
| protocol: TCP | ||
| volumeMounts: | ||
| {{- if .Values.global.cacheUseHostPath }} | ||
| - mountPath: /home/user/.cache/clip | ||
| name: cache-volume | ||
| subPath: clip | ||
| - mountPath: /home/user/.cache/huggingface/hub | ||
|
yongfengdu marked this conversation as resolved.
|
||
| name: cache-volume | ||
| subPath: huggingface/hub | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When using model-volume, the subPath is not necessary.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agree, not necessary. But I suppose, as same volume is being re-used to mount different paths from different pod/containers, having a subPath helps to have a proper directory hierarchy inside model-volume and helps with what is coming from which container path instead of dumping everything in the root of model-volume.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The model-volume was used to save the models downloaded from huggingface hub, which is the HUGGINGFACE_HUB_CACHE here https://huggingface.co/docs/text-generation-inference/en/reference/launcher#huggingfacehubcache |
||
| {{- end }} | ||
| - mountPath: /tmp | ||
| name: tmp | ||
| {{- if .Values.livenessProbe }} | ||
|
|
@@ -63,6 +80,12 @@ spec: | |
| resources: | ||
| {{- toYaml .Values.resources | nindent 12 }} | ||
| volumes: | ||
| {{- if .Values.global.cacheUseHostPath }} | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See comment above.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| - name: cache-volume | ||
| hostPath: | ||
| path: {{ .Values.global.cacheUseHostPath }} | ||
| type: Directory | ||
| {{- end }} | ||
| - name: tmp | ||
| emptyDir: {} | ||
| {{- with .Values.nodeSelector }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to change the file name vdms-values.yaml to variant_vdms-values.yaml so the update_manifest.sh can automatically pick this to generate manifests files for GMC. Please see llm_uservice as example
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| image: | ||
| repository: opea/dataprep-multimodal-vdms | ||
| pullPolicy: IfNotPresent | ||
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "latest" | ||
|
|
||
| indexName: "mega-videoqna" | ||
| vdmsHost: "" | ||
| vdmsPort: "8001" | ||
| entryCommand: ["/bin/sh"] | ||
| extraArgs: ["-c", "sleep 15 && python ingest_videos.py"] | ||
|
|
||
| # Set cacheUseHostPath to for caching encoding/embedding models and other related data | ||
| global: | ||
| cacheUseHostPath: "" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. again, please change use the variant_vdms-values.yaml as the file names so update_manifest.sh can pick it up automatically.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| image: | ||
| repository: opea/embedding-multimodal-clip | ||
| pullPolicy: IfNotPresent | ||
| # Overrides the image tag whose default is the chart appVersion. | ||
| tag: "latest" | ||
|
|
||
| securityContext: | ||
| readOnlyRootFilesystem: false | ||
|
|
||
| # Set cacheUseHostPath to for caching encoding/embedding models and other related data | ||
| global: | ||
| cacheUseHostPath: "" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Patterns to ignore when building packages. | ||
| # This supports shell glob matching, relative path matching, and | ||
| # negation (prefixed with !). Only one pattern per line. | ||
| .DS_Store | ||
| # Common VCS dirs | ||
| .git/ | ||
| .gitignore | ||
| .bzr/ | ||
| .bzrignore | ||
| .hg/ | ||
| .hgignore | ||
| .svn/ | ||
| # Common backup files | ||
| *.swp | ||
| *.bak | ||
| *.tmp | ||
| *.orig | ||
| *~ | ||
| # Various IDEs | ||
| .project | ||
| .idea/ | ||
| *.tmproj | ||
| .vscode/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| apiVersion: v2 | ||
| name: lvm-serving | ||
|
yongfengdu marked this conversation as resolved.
Outdated
|
||
| description: A Helm chart for serving LVM | ||
| type: application | ||
| version: 1.0.0 | ||
| appVersion: "v1.0" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| {{/* | ||
| Expand the name of the chart. | ||
| */}} | ||
| {{- define "lvm-serving.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create a default fully qualified app name. | ||
| We truncate at 63 chars because some Kubernetes name fields are limited to this (by the DNS naming spec). | ||
| If release name contains chart name it will be used as a full name. | ||
| */}} | ||
| {{- define "lvm-serving.fullname" -}} | ||
| {{- if .Values.fullnameOverride }} | ||
| {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- $name := default .Chart.Name .Values.nameOverride }} | ||
| {{- if contains $name .Release.Name }} | ||
| {{- .Release.Name | trunc 63 | trimSuffix "-" }} | ||
| {{- else }} | ||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create chart name and version as used by the chart label. | ||
| */}} | ||
| {{- define "lvm-serving.chart" -}} | ||
| {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Common labels | ||
| */}} | ||
| {{- define "lvm-serving.labels" -}} | ||
| helm.sh/chart: {{ include "lvm-serving.chart" . }} | ||
| {{ include "lvm-serving.selectorLabels" . }} | ||
| {{- if .Chart.AppVersion }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| {{- end }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Selector labels | ||
| */}} | ||
| {{- define "lvm-serving.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "lvm-serving.name" . }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end }} | ||
|
|
||
| {{/* | ||
| Create the name of the service account to use | ||
| */}} | ||
| {{- define "lvm-serving.serviceAccountName" -}} | ||
| {{- if .Values.serviceAccount.create }} | ||
| {{- default (include "lvm-serving.fullname" .) .Values.serviceAccount.name }} | ||
| {{- else }} | ||
| {{- default "default" .Values.serviceAccount.name }} | ||
| {{- end }} | ||
| {{- end }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # Copyright (C) 2024 Intel Corporation | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: {{ include "lvm-serving.fullname" . }}-config | ||
| labels: | ||
| {{- include "lvm-serving.labels" . | nindent 4 }} | ||
| data: | ||
| llm_download: {{ .Values.llmDownload | quote | title }} | ||
| http_proxy: {{ .Values.global.http_proxy | quote }} | ||
| https_proxy: {{ .Values.global.https_proxy | quote }} | ||
| no_proxy: {{ .Values.global.no_proxy | quote }} |
Uh oh!
There was an error while loading. Please reload this page.