Skip to content

[TDX] Added Intel TDX support to docsum helm charts #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ksandowi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[TDX] Added Intel TDX support to docsum helm charts #818

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b22c27
Added TDX support to docsum helm charts, startup command added to mai…
Feb 18, 2025
10803cc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 18, 2025
232981f
Comment fixed in README.md
ksandowi Feb 19, 2025
eaf193f
Main service enabled with TDX. Description updated in docsum README.md
ksandowi Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions helm-charts/common/whisper/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,7 @@ type: application
version: 0-latest
# The whisper microservice server version
appVersion: "v1.0"
dependencies:
- name: commonlib
version: 0-latest
repository: "file://../commonlib"
6 changes: 2 additions & 4 deletions helm-charts/common/whisper/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,11 @@ spec:
{{- include "whisper.selectorLabels" . | nindent 6 }}
template:
metadata:
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- include "common.annotations" . | nindent 6 }}
labels:
{{- include "whisper.selectorLabels" . | nindent 8 }}
spec:
{{- include "common.runtimeClassName" . | indent 6 }}
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/common/whisper/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ tolerations: []

affinity: {}

tdxEnabled: false

global:
http_proxy: ""
https_proxy: ""
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/docsum/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --se
# helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --values docsum/gaudi-tgi-values.yaml ...
# To use Gaudi device with vLLM
# helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --values docsum/gaudi-vllm-values.yaml ..
# To run docsum with Intel TDX feature
# helm install docsum docsum --set global.HUGGINGFACEHUB_API_TOKEN=${HFTOKEN} --set tgi.LLM_MODEL_ID=${MODELNAME} --set docsum.tdxEnabled=true --set docsum.resources.limits.memory=1Gi --set docsum-ui.tdxEnabled=true --set docsum-ui.resources.limits.memory=2Gi --set llm-uservice.tdxEnabled=true --set llm-uservice.resources.limits.memory=4Gi --set tgi.tdxEnabled=true --set tgi.resources.limits.memory=80Gi --set whisper.tdxEnabled=true --set whisper.resources.limits.memory=13Gi
Copy link
Copy Markdown
Contributor

@JakubLedworowski JakubLedworowski Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docsum-ui not enabled

Copy link
Copy Markdown
Author

@ksandowi ksandowi Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is with this line:
--set docsum-ui.tdxEnabled=true --set docsum-ui.resources.limits.memory=2Gi

```

## Verify
Expand Down