ci: resolve chocolatey packaging paths working-directory-relative - #17
Merged
Conversation
The reusable release.yml chocolatey job hardcoded repo-root-relative
packaging/chocolatey paths, so a monorepo tool's
tools/<tool>/packaging/chocolatey could not be found. Add
working-directory: ${{ inputs.working-directory }} to the two steps that
reference those paths (the checksum-download step is path-agnostic and is
left alone). Flat repos pass ".", so resolution is unchanged.
Second monorepo gap surfaced during the atlassian-cli#397 survey, sibling
to the identity-check repo-root fix (#14/#15).
Closes #16
Contributor
Author
|
Findings No findings. The fix is complete and correctly scoped:
After merge, cut/repoint |
monit-reviewer
approved these changes
May 30, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 5222b2c
Summary
No issues found.
1 PR discussion thread considered.
Completed in 10s | $0.15 | sonnet | daemon 0.2.121 | Glorfindel
| Field | Value |
|---|---|
| Model | sonnet |
| Reviewers | hybrid-synthesis, harness-engineering:harness-architecture-reviewer, harness-engineering:harness-enforcement-reviewer, harness-engineering:harness-knowledge-reviewer |
| Engine | claude · sonnet |
| Reviewed by | pr-review-daemon · monit-pr-reviewer |
| Duration | 10s wall · 12s compute (Reviewers: 4s · Synthesis: 4s) |
| Cost | $0.15 |
| Tokens | 57.9k in / 359 out |
| Turns | 4 |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost |
|---|---|---|---|---|---|---|
| hybrid-synthesis | sonnet | 29.6k | 53 | 18.6k | 10.9k (1h) | $0.05 |
| harness-engineering:harness-architecture-reviewer | sonnet | 9.5k | 113 | 2.1k | 7.3k (1h) | $0.03 |
| harness-engineering:harness-enforcement-reviewer | sonnet | 9.5k | 109 | 2.1k | 7.3k (1h) | $0.03 |
| harness-engineering:harness-knowledge-reviewer | sonnet | 9.5k | 84 | 2.1k | 7.3k (1h) | $0.03 |
Re-reviews only run when @monit-reviewer is re-requested as a reviewer — push as many commits as you need, then re-request when ready. PRs targeting branches other than main, master are skipped, even when @monit-reviewer is re-requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
working-directory: ${{ inputs.working-directory }}to the two chocolatey steps in the reusablerelease.ymlthat referencepackaging/chocolateypaths:packaging/chocolatey/$CHOCO_ID.nuspec+packaging/chocolatey/tools/chocolateyInstall.ps1.cd packaging/chocolatey.The Get checksums from release step downloads
checksums.txtto.and is path-agnostic, so it is left unchanged.Why
The chocolatey job hardcoded repo-root-relative packaging paths, so a monorepo tool's
tools/<tool>/packaging/chocolateycould not be found — the second monorepo gap surfaced during the atlassian-cli#397 survey (sibling to the identity-check repo-root fix, #14/#15). The other channel jobs are already monorepo-correct: winget useswingetcreate updateagainst the published manifest, and homebrew/linux/goreleaser/auto-release resolve relative to working-directory (or run goreleaser from root by design).Per-step
working-directory(not a job-leveldefaults.run.working-directory) is used deliberately — GHAdefaultsis not a safe place to interpolateinputs.*.Backward-compatible: flat repos pass working-directory
., so paths resolve identically to today.Testing
The choco job is Windows + secret-gated (
chocolatey-api-key), so — like the darwin-gatecheck-machohalf — it can't run end-to-end in CI; the structural change is validated by YAML parse + the real end-to-end proof on atlassian-cli#397's first monorepo choco release. After merge: cutv1.1.1and re-point the moving@v1tag.Closes #16