Skip to content

fix: verify self-signed macOS releases after signing #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 1 commit into from
Aug 11, 2026
Merged

fix: verify self-signed macOS releases after signing #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ jobs:
echo "::error::MACOS_CERT_LEAF_SHA is not the expected stable certificate leaf"
exit 1
fi
if ! security find-identity -v -p codesigning | grep -i -F "$expected_leaf" >/dev/null; then
echo "::error::imported macOS signing identity does not match the expected certificate leaf"
exit 1
fi

- name: Stable-sign macOS app
if: matrix.os == 'macos-15'
Expand Down
13 changes: 10 additions & 3 deletions scripts/check-release.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,16 @@ for (const secret of [
]) required(workflow, secret)
required(workflow, 'stable macOS signing credentials are required')
required(workflow, '42e1afd02aae8666c09c15f171e1639550f301c2')
required(workflow, 'identifier "com.rianjs.retune"')
required(workflow, 'certificate leaf')
required(workflow, 'codesign --verify --deep --strict')
const verifyStepName = '- name: Verify macOS app signature'
const verifyStep = workflow.match(/- name: Verify macOS app signature\n[\s\S]*?(?=\n - name:)/)?.[0] ?? ''
required(verifyStep, verifyStepName)
required(verifyStep, 'codesign --verify --deep --strict "$app"')
required(verifyStep, 'for target in "$executable" "$app"; do')
required(verifyStep, 'codesign --verify --strict "$target"')
required(verifyStep, 'requirement="$(codesign -d -r- "$target" 2>&1 | sed -n \'s/^designated => //p\')"')
required(verifyStep, '*\'identifier "com.rianjs.retune"\'*\'certificate leaf = H"42e1afd02aae8666c09c15f171e1639550f301c2"\'*) ;;')
required(verifyStep, '*cdhash*) echo "::error::macOS designated requirement contains cdhash for $target"; exit 1 ;;')
assert.doesNotMatch(workflow, /security\s+find-identity/)
assert.doesNotMatch(workflow, /--timestamp(?:=|\s)/)
assert.doesNotMatch(workflow, /--options\s+runtime/)
assert.doesNotMatch(workflow, /notarytool/i)
Expand Down
Loading