fix(jtk)!: shape-stable fulltext, fail-closed sprint resolution, deterministic automation export - #461
Closed
rianjs wants to merge 17 commits into
Closed
fix(jtk)!: shape-stable fulltext, fail-closed sprint resolution, deterministic automation export#461rianjs wants to merge 17 commits into
rianjs wants to merge 17 commits into
Conversation
…rministic automation export (#455)
# Conflicts: # tools/jtk/internal/cmd/comments/comments.go # tools/jtk/internal/cmd/comments/comments_fields_test.go # tools/jtk/internal/cmd/issues/list.go # tools/jtk/internal/present/comment.go # tools/jtk/internal/present/comment_test.go
![rianjs-bot[bot]](https://avatars.githubusercontent.com/u/7378790?s=60&v=4){kind=small}
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 3eaf12503cfb
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| structure:repo-health | 0 |
| documentation:docs | 1 |
documentation:docs (1 finding)
Minor - tools/jtk/internal/cmd/OUTPUT_SPEC.md:297
The
--fulltextexample still ends the body with..., even though the preceding text now says truncation is disabled. The renderer only appends an ellipsis when fulltext is false, so this example teaches the opposite behavior. Show the complete sample body (or clearly mark omitted illustrative text outside the command-output block).
Reviewer Coverage
| Reviewer | Status | Inspected | Skipped | Constraints |
|---|---|---|---|---|
| go:implementation-tests | complete_broad | tools/jtk/internal/cmd/automation/export.go, tools/jtk/internal/cmd/automation/export_test.go, tools/jtk/internal/cmd/comments/comments.go, tools/jtk/internal/cmd/comments/comments_fields_test.go, tools/jtk/internal/cmd/comments/comments_test.go, tools/jtk/internal/cmd/issues/get.go, tools/jtk/internal/cmd/issues/get_test.go, tools/jtk/internal/cmd/issues/list.go, tools/jtk/internal/cmd/issues/list_test.go, tools/jtk/internal/present/comment.go, tools/jtk/internal/present/comment_test.go | unavailable | Review limited to assigned Go implementation and test files. Package tests compiled with CGO disabled, but execution was blocked because the sandbox disallows httptest TCP listeners. |
| policies:conventions | complete_broad | tools/jtk/README.md, tools/jtk/internal/cmd/OUTPUT_SPEC.md, tools/jtk/internal/cmd/automation/export.go, tools/jtk/internal/cmd/comments/comments.go, tools/jtk/internal/cmd/issues/get.go, tools/jtk/internal/cmd/issues/list.go | unavailable | Shared cli-common convention documents were not available locally; reviewed against the repository-local standards and command specifications.; Targeted Go tests could not run because the environment's clang invocation mishandled the workspace path containing spaces. |
| structure:repo-health | complete_broad | tools/jtk/internal/cmd/OUTPUT_SPEC.md, tools/jtk/internal/cmd/automation/export.go, tools/jtk/internal/cmd/comments/comments.go, tools/jtk/internal/cmd/issues/get.go, tools/jtk/internal/cmd/issues/list.go, tools/jtk/internal/present/comment.go | unavailable | Sandbox path prevents Go test compilation. |
| documentation:docs | complete_broad | skills/Jira/CliReference.md, skills/Jira/SKILL.md, skills/Jira/Workflows/ManageComments.md, tools/jtk/CHANGELOG.md, tools/jtk/README.md, tools/jtk/internal/cmd/OUTPUT_SPEC.md | unavailable | Documentation-focused review; verified changed claims against local command implementation and tests, without live Jira/API access. |
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 3m 05s | unavailable | gpt-5.6-terra | cr 0.10.259
| Field | Value |
|---|---|
| Model | gpt-5.6-terra |
| Reviewers | go:implementation-tests, policies:conventions, structure:repo-health, documentation:docs |
| Engine | codex_cli · gpt-5.6-terra |
| Reviewed by | cr · rianjs-bot[bot] |
| Duration | 3m 05s wall · 8m 27s compute |
| Cost | unavailable |
| Tokens | 1.7M in / 15.6k out |
Per-workstream usage
| Workstream | Model | In | Out | Cache read | Cache create | Cost | Duration |
|---|---|---|---|---|---|---|---|
| orchestrator-selection | gpt-5.6-terra | 15.8k | 519 | 10.5k | unavailable | unavailable | 12s |
| go:implementation-tests | gpt-5.6-terra | 723.5k | 4.6k | 654.3k | unavailable | unavailable | 2m 32s |
| policies:conventions | gpt-5.6-terra | 281.1k | 2.9k | 230.9k | unavailable | unavailable | 1m 31s |
| structure:repo-health | gpt-5.6-terra | 347.6k | 3.2k | 285.7k | unavailable | unavailable | 2m 39s |
| documentation:docs | gpt-5.6-terra | 322.2k | 3.8k | 260.6k | unavailable | unavailable | 1m 28s |
| orchestrator-rollup | gpt-5.6-terra | 34.2k | 579 | 26.1k | unavailable | unavailable | 3s |
| ... | ||
| ID | AUTHOR | CREATED | BODY | ||
| 21242 | Aaron Wong | 2026-04-16 | Short audit conclusion after the current code changes: | ||
| The major source-level accessibility findings on CapOne-specific surfaces appear to be addressed or materially improved: ... |
There was a problem hiding this comment.
The --fulltext example still ends the body with ..., even though the preceding text now says truncation is disabled. The renderer only appends an ellipsis when fulltext is false, so this example teaches the opposite behavior. Show the complete sample body (or clearly mark omitted illustrative text outside the command-output block).
Reply inline to this comment.
# Conflicts: # skills/Jira/SKILL.md
# Conflicts: # tools/jtk/README.md
# Conflicts: # skills/Jira/SKILL.md
Contributor
Author
|
GitHub auto-closed this when its stacked base branch was deleted during the merge train; the identical content merges via #463. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements items 11, 13, and 17 of #455. Stacked on #460; will retarget as bases merge.
comments list --fulltextnow keeps the table shape and only disables truncation (previously it switched to detail blocks — deliberate behavior change per the spec). Deprecated--no-truncatealias removed.--fieldsprojection and--idprecedence preserved.issues list --sprintfails closed on sprint-name ambiguity or resolution failure: ambiguous names error with candidate IDs, unresolved names error with refresh/ID guidance; no more fallback to broad name-based JQL.sprints issues/sprints addbehavior (already fail-closed) unchanged.automation exportis deterministic: defaultjson.Indent,--compactusesjson.Compact(previously raw passthrough), malformed API JSON errors with empty stdout.