Skip to content

fix: use tap token for homebrew publishing #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 1 commit into from
Jun 3, 2026
Merged

fix: use tap token for homebrew publishing #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ on:
default: true

# The tag push uses the dedicated RELEASE_TAG_TOKEN via a credential helper, not
# GITHUB_TOKEN, so the pushed tag retriggers release.yml. HOMEBREW_TAP_TOKEN is
# GITHUB_TOKEN, so the pushed tag retriggers release.yml. TAP_GITHUB_TOKEN is
# only for release.yml Homebrew tap pushes.
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
# — this is robust to either and always yields a real boolean.
dry-run: ${{ github.event_name == 'workflow_dispatch' && (inputs.dry-run == true || inputs.dry-run == 'true') }}
secrets:
homebrew-tap-token: ${{ secrets.HOMEBREW_TAP_TOKEN }}
homebrew-tap-token: ${{ secrets.TAP_GITHUB_TOKEN }}
chocolatey-api-key: ${{ secrets.CHOCOLATEY_API_KEY }}
winget-token: ${{ secrets.WINGET_GITHUB_TOKEN }}
linux-dispatch-token: ${{ secrets.LINUX_PACKAGES_DISPATCH_TOKEN }}
4 changes: 2 additions & 2 deletions docs/development.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ package-channel credentials. The preferred long-term shape is the GitHub App
installation-token path described in the shared release standard; until that is
wired through, use a narrowly scoped `RELEASE_TAG_TOKEN`.

`HOMEBREW_TAP_TOKEN` is only for Homebrew tap pushes from the release workflow.
`TAP_GITHUB_TOKEN` is only for Homebrew tap pushes from the release workflow.
Do not reuse it for auto-release tag pushes.

Package-channel releases also use `CHOCOLATEY_API_KEY`,
Expand All @@ -71,7 +71,7 @@ shared workflow owns publish mechanics.

- Homebrew: GoReleaser renders `dist/homebrew/Casks/codereview-cli.rb` with
`skip_upload: true`; the shared Homebrew job pushes that generated cask to
`open-cli-collective/homebrew-tap` with `HOMEBREW_TAP_TOKEN`.
`open-cli-collective/homebrew-tap` with `TAP_GITHUB_TOKEN`.
- Chocolatey: the shared Chocolatey job rewrites
`packaging/chocolatey/cr.nuspec` from version `0.0.0` to the release version
and replaces `CHECKSUM_AMD64_PLACEHOLDER` /
Expand Down
2 changes: 1 addition & 1 deletion scripts/verify-package-render.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ require_grep "<id>cr</id>" "packaging/chocolatey/cr.nuspec"
require_grep 'releases/download/v${version}' "packaging/chocolatey/tools/chocolateyInstall.ps1"
require_grep 'cr_v${version}_windows_${arch}.zip' "packaging/chocolatey/tools/chocolateyInstall.ps1"

require_grep 'homebrew-tap-token: ${{ secrets.HOMEBREW_TAP_TOKEN }}' ".github/workflows/release.yml"
require_grep 'homebrew-tap-token: ${{ secrets.TAP_GITHUB_TOKEN }}' ".github/workflows/release.yml"
require_grep 'chocolatey-api-key: ${{ secrets.CHOCOLATEY_API_KEY }}' ".github/workflows/release.yml"
require_grep 'winget-token: ${{ secrets.WINGET_GITHUB_TOKEN }}' ".github/workflows/release.yml"
require_grep 'linux-dispatch-token: ${{ secrets.LINUX_PACKAGES_DISPATCH_TOKEN }}' ".github/workflows/release.yml"
Expand Down
Loading