Skip to content

fix: remove darwin probe seed traversal #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rianjs merged 1 commit into from
Jun 3, 2026
Merged

fix: remove darwin probe seed traversal #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packaging/identity.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ archives:
# nuspec/winget manifests and run secretless channel jobs. Channels (and the
# homebrew canonical_cask) are added when each is actually implemented.

# The shared darwin gate writes seed_config.path under XDG_CONFIG_HOME. cr's
# statedir-based config path resolves through os.UserConfigDir(); on macOS with
# hermetic HOME that is "$HOME/Library/Application Support/codereview/config.yml".
# The relative ".." intentionally escapes XDG_CONFIG_HOME back to HOME so the
# probe seeds the path cr actually reads.
# cr's statedir-based config path resolves through os.UserConfigDir(); on macOS
# with hermetic HOME that is "$HOME/Library/Application Support". The shared
# darwin gate's native_user_config seed base writes under that root without
# path traversal.
keychain_probe:

@monit-reviewer monit-reviewer Jun 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Low (harness-engineering:harness-architecture-reviewer): The functional correctness of base: native_user_config resolving to the correct path and backend_source: auto selecting Keychain on darwin arm64 cannot be verified by the listed checks (rg, identity.py validate, actionlint, go test, golangci-lint), which are all structural or Linux-hosted. Per the PR author's own comment, the shared distribution standard defers this to a release-time Apple Silicon run — meaning a silent regression is possible if native_user_config resolves differently than the old traversal in the hermetic HOME environment. Consider documenting the expected hermetic HOME resolution behavior of native_user_config in a comment or accompanying doc.

Reply to this thread when addressed.

env_unset: [CODEREVIEW_KEYRING_BACKEND]
seed_config:
path: "../Library/Application Support/codereview/config.yml"
base: native_user_config
path: "codereview/config.yml"
content: |
default_profile: default
profiles:
Expand Down
Loading