add deterministic sorting to model revision list query - #7363
Open
andersendsa wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
Geti Backend
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the backend ModelRevisionRepository.list_all query to return model revisions in a consistent order, addressing inconsistent ordering across environments by adding an explicit ORDER BY.
Changes:
- Added an
order_byclause to sort model revisions bycreated_at(descending) andname(ascending).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| if training_status is not None: | ||
| stmt = stmt.where(ModelRevisionDB.training_status == training_status) | ||
|
|
||
| stmt = stmt.order_by(ModelRevisionDB.created_at.desc(), ModelRevisionDB.name.asc()) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added an
order_byclause toModelRevisionRepository.list_allto order bycreated_atdescending andnameascending. This fixes inconsistent model ordering observed between environments.Closes:#6212
Checklist