fix(test): flaky persona / task filter spec failure by chirag-madlani · Pull Request #27880 · open-metadata/OpenMetadata

chirag-madlani · 2026-05-04T06:01:50Z

Describe your changes:

PersonaFlow.spec.ts

We had default Persona failing causing org level default persona set which cause issue with team persona flow as deafult org get's priority

CustomizeWidget.spec.ts

Task filter tries to filter before the task gets loaded

I worked on ... because ...

Type of change:

Checklist:

I have read the CONTRIBUTING document.
My PR title is Fixes <issue-number>: <short explanation>
I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copilot

Pull request overview

Improves Playwright E2E test stability around persona defaulting and widget filter timing to reduce flaky spec failures in the UI test suite.

Changes:

Added an afterAll teardown to delete the user and personas created for the “default persona” flow.
Added a pre-check in the “Activity Feed Widget” test to ensure task cards are present before running widget filter assertions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/PersonaFlow.spec.ts	Adds teardown cleanup for entities created during the default persona flow to avoid cross-test interference.
openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts	Adds a guard before applying Activity Feed widget filters to avoid filtering before content loads.

+      await Promise.all([
+        user.delete(apiContext),
+        persona1.delete(apiContext),
+        persona2.delete(apiContext),
+      ]);


  await test.step('Test widget filters', async () => {
    await waitForAllLoadersToDisappear(page);
    await waitForAllLoadersToDisappear(page, 'entity-list-skeleton');
+    expect(await page.getByTestId('task-feed-card').count()).toBeGreaterThan(0);


github-actions · 2026-05-04T06:26:15Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	62.45% (62922/100755)	42.77% (33911/79285)	45.77% (10035/21924)

github-actions · 2026-05-04T08:31:29Z

🟡 Playwright Results — all passed (14 flaky)

✅ 3985 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 86 skipped

Shard	Passed	Flaky	Skipped
🟡 Shard 1	298	1	4
🟡 Shard 2	747	7	8
🟡 Shard 3	744	3	7
🟡 Shard 4	774	1	18
✅ Shard 5	687	0	41
🟡 Shard 6	735	2	8

🟡 14 flaky test(s) (passed on retry)

Features/DataAssetRulesDisabled.spec.ts › Verify the SearchIndex Service entity item action after rules disabled (shard 1, 1 retry)
Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
Features/ActivityAPI.spec.ts › Activity event shows the actor who made the change (shard 2, 1 retry)
Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › EditAll User: Complete export-import-validate flow (shard 2, 1 retry)
Features/DataQuality/TestCaseResultPermissions.spec.ts › User with TEST_CASE.EDIT_ALL can see edit action on test case (shard 2, 1 retry)
Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
Features/Glossary/GlossaryWorkflow.spec.ts › should display correct status badge color and icon (shard 2, 1 retry)
Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
Features/SearchExport.spec.ts › Browse mode visible export downloads CSV with current page row count (shard 3, 1 retry)
Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
Pages/Domains.spec.ts › Subdomain rename does not affect parent domain and updates nested children (shard 4, 1 retry)
Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)

📦 Download artifacts

How to debug locally

# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

gitar-bot · 2026-05-04T13:17:02Z

Code Review ✅ Approved 1 resolved / 1 findings

Stabilizes Persona and task filter specs by adding missing await assertions on task feed cards. No issues found.

✅ 1 resolved

✅ Edge Case: Missing await on expect assertion for task feed cards

📄 openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts:206
At line 206, expect(await page.getByTestId('task-feed-card').count()).toBeGreaterThan(0) uses a raw expect without await. This performs a one-shot check: if no task cards are rendered yet (e.g., async data still arriving after loaders disappear), the assertion will fail immediately rather than retrying. Using Playwright's web-first assertion with await expect(page.getByTestId('task-feed-card').first()).toBeVisible() would auto-retry for up to the configured timeout, making it more resilient to timing variations — which is the whole purpose of this fix.

Options

Display: compact → Showing less information.

Comment with these commands to change:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Gitar}

sonarqubecloud · 2026-05-04T13:44:39Z

Quality Gate passed for 'open-metadata-ui'

Issues
1062 New issues
0 Accepted issues

Measures
17 Security Hotspots
0.0% Coverage on New Code
3.8% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-05-04T15:44:18Z

Failed to cherry-pick changes to the 1.13 branch.
Please cherry-pick the changes manually.
You can find more details here.

github-actions · 2026-05-04T15:44:19Z

Failed to cherry-pick changes to the 1.12.7 branch.
Please cherry-pick the changes manually.
You can find more details here.

) * fix(test): flaky persona / task filter spec failure * fix wait for task card * fix checkstyle * fix for task filter widget

fix(test): flaky persona / task filter spec failure

f891cd9

Copilot AI review requested due to automatic review settings May 4, 2026 06:01

chirag-madlani requested a review from a team as a code owner May 4, 2026 06:01

github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels May 4, 2026

Copilot started reviewing on behalf of chirag-madlani May 4, 2026 06:02 View session

chirag-madlani added the To release Will cherry-pick this PR into the release branch label May 4, 2026

gitar-bot Bot reviewed May 4, 2026

View reviewed changes

Comment thread openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts Outdated

Copilot AI reviewed May 4, 2026

View reviewed changes

chirag-madlani temporarily deployed to test May 4, 2026 06:13 — with GitHub Actions Inactive

chirag-madlani had a problem deploying to test May 4, 2026 06:13 — with GitHub Actions Failure

chirag-madlani temporarily deployed to test May 4, 2026 06:13 — with GitHub Actions Inactive

fix wait for task card

0fd1be0

chirag-madlani had a problem deploying to test May 4, 2026 09:59 — with GitHub Actions Error

chirag-madlani temporarily deployed to test May 4, 2026 09:59 — with GitHub Actions Inactive

chirag-madlani had a problem deploying to test May 4, 2026 09:59 — with GitHub Actions Error

fix checkstyle

e603f96

Copilot AI review requested due to automatic review settings May 4, 2026 10:59

Copilot started reviewing on behalf of chirag-madlani May 4, 2026 11:00 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Comment thread openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/PersonaFlow.spec.ts

Comment thread openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts Outdated

chirag-madlani had a problem deploying to test May 4, 2026 11:11 — with GitHub Actions Failure

chirag-madlani had a problem deploying to test May 4, 2026 11:11 — with GitHub Actions Error

chirag-madlani temporarily deployed to test May 4, 2026 11:11 — with GitHub Actions Inactive

fix for task filter widget

569e283

chirag-madlani temporarily deployed to test May 4, 2026 13:26 — with GitHub Actions Inactive

harsh-vador approved these changes May 4, 2026

View reviewed changes

chirag-madlani enabled auto-merge (squash) May 4, 2026 15:22

chirag-madlani merged commit d14cb87 into main May 4, 2026
47 checks passed

chirag-madlani deleted the fix-flaky-pw-tests branch May 4, 2026 15:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(test): flaky persona / task filter spec failure#27880

fix(test): flaky persona / task filter spec failure#27880
chirag-madlani merged 4 commits intomainfrom
fix-flaky-pw-tests

chirag-madlani commented May 4, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

gitar-bot Bot commented May 4, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented May 4, 2026

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chirag-madlani commented May 4, 2026

Describe your changes:

Type of change:

Checklist:

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented May 4, 2026

Jest test Coverage

UI tests summary

Uh oh!

github-actions Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟡 Playwright Results — all passed (14 flaky)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

gitar-bot Bot commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented May 4, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 4, 2026 •

edited

Loading

gitar-bot Bot commented May 4, 2026 •

edited

Loading