Skip to content

Fixed ServiceDoc Panel flaky behaviour#27884

Merged
Rohit0301 merged 2 commits intomainfrom
fix-service-doc-spec
May 4, 2026
Merged

Fixed ServiceDoc Panel flaky behaviour#27884
Rohit0301 merged 2 commits intomainfrom
fix-service-doc-spec

Conversation

@Rohit0301
Copy link
Copy Markdown
Contributor

@Rohit0301 Rohit0301 commented May 4, 2026

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Summary by Gitar

  • Testing:
    • Removed flaky test cases from ServiceDocPanel.spec.ts to stabilize the test suite.
  • Workflow cleanup:
    • Removed the task workflow from the OSS codebase.

This will update automatically on new commits.

@Rohit0301 Rohit0301 self-assigned this May 4, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner May 4, 2026 11:04
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.45% (62922/100755) 42.77% (33911/79285) 45.77% (10035/21924)

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 4, 2026

Code Review ✅ Approved

Stabilizes the ServiceDoc test suite by removing flaky test cases in ServiceDocPanel.spec.ts. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

🟡 Playwright Results — all passed (9 flaky)

✅ 3989 passed · ❌ 0 failed · 🟡 9 flaky · ⏭️ 86 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 298 0 1 4
🟡 Shard 2 752 0 2 8
🟡 Shard 3 744 0 2 7
🟡 Shard 4 772 0 3 18
✅ Shard 5 687 0 0 41
🟡 Shard 6 736 0 1 8
🟡 9 flaky test(s) (passed on retry)
  • Flow/Collect.spec.ts › Visit Insights page should trigger collect API (shard 1, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when description is updated (shard 2, 1 retry)
  • Features/ActivityAPI.spec.ts › Activity event is created when owner is added (shard 2, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Should clear search and show all properties for apiCollection in right panel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Contract Status badge should be visible on condition if Contract Tab is present/hidden by Persona (shard 4, 1 retry)
  • Pages/DataInsightReportApplication.spec.ts › Uninstall application (shard 4, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@Rohit0301 Rohit0301 merged commit 5e259d7 into main May 4, 2026
47 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Changes have been cherry-picked to the 1.12.7 branch.

github-actions Bot pushed a commit that referenced this pull request May 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Changes have been cherry-picked to the 1.13 branch.

github-actions Bot pushed a commit that referenced this pull request May 4, 2026
@Rohit0301 Rohit0301 deleted the fix-service-doc-spec branch May 4, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants