-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(search): restore live settings on per-entity promote path #27920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+80
−5
Merged
Changes from 23 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
83b803c
Restore live index settings on per-entity distributed-promote path
harshach ba952d9
Wire jobData into per-entity reindex promotion handler
harshach 80f01f6
Add regression test for live serving settings on per-entity promote
harshach c373592
Expand unit coverage around the per-entity promotion contract
harshach 20e1cd4
Add integration test for live settings restoration after alias promotion
harshach a977032
Address PR review: harden settings revert + lock InOrder + drop redun…
harshach a2a2b4a
Drop verbose explanatory comments from promote-path edits
harshach f40a21b
Close Rest5Client in IT _settings helper
harshach 4775e90
Tighten SearchIndexAliasPromotionIT against false-positive runs
harshach 2af5827
Harden alias promotion: defer canonical delete, hard-fail on empty al…
harshach 4654158
Consolidate finalizeReindex and promoteEntityIndex into one core path
harshach 9a7fa49
Address PR review: post-state checks, FAILED listener, hermetic IT, I…
harshach 8b4d1a8
Wrap post-state checks: indexExists / getAliases throws no longer escape
harshach 2580597
Address Copilot review 4232747647: positive-evidence dataLoss, hermet…
harshach 0351078
Merge branch 'main' into harshach/search-alias-promote
harshach 30774c7
Wait for restore-triggered run to settle in SearchIndexAliasPromotionIT
harshach 232d195
Fix AppsResourceIT.waitForAppJobCompletion case mismatch and timeout
harshach 22717f5
Merge branch 'main' into harshach/search-alias-promote
mohityadav766 98b9871
Merge remote-tracking branch 'origin/main' into harshach/search-alias…
harshach aee61f2
Merge branch 'harshach/search-alias-promote' of github.com:open-metad…
harshach 64a385a
Run SearchIndexAliasPromotionIT in the sequential bucket
harshach 810ed16
Address Copilot PR review 4233452655
harshach cf18270
Remove SearchIndexAliasPromotionIT in favor of unit test coverage
harshach 7d7e5db
Address Copilot PR review 4236718653
harshach bb973d8
Fix per-entity promote when canonical is an alias, not a concrete index
harshach 0164cd8
Add ALIAS_PROMOTE_BEGIN diagnostic log per entity
harshach d80e44b
Drop heavy alias-promotion refactor; rely on PR #27930 fix already in…
harshach 3e0d7ca
Merge remote-tracking branch 'origin/main' into harshach/search-alias…
harshach 25240ec
Skip delete-by-alias-name when canonical is currently an alias
harshach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.