Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds additional debug-level logging around PowerBI lineage creation to make it easier to troubleshoot missing entities (dashboard/report/datamodel) and missing dataset IDs during lineage processing.
Changes:
- Added granular
logger.debugstatements in report↔dashboard lineage creation (including per-tile report linkage and missing-entity cases). - Added debug logs in datamodel↔report lineage creation, including datasetId presence vs. datasource API extraction path.
- Corrected
_fetch_report_from_workspacereturn type annotation toOptional[PowerBIReport].
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
ingestion/src/metadata/ingestion/source/dashboard/powerbi/metadata.py:765
- The return type annotation is inconsistent with the yielded values. This method yields
_get_add_lineage_request(...), which producesEither[AddLineageRequest](orNone), notEither[CreateDashboardRequest]. Please update the return type toIterable[Either[AddLineageRequest]](and ensure you neveryield None).
def create_datamodel_report_lineage(
self,
db_service_prefix: Optional[str], # noqa: UP045
dashboard_details: PowerBIReport,
) -> Iterable[Either[CreateDashboardRequest]]:
"""
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
🔴 Playwright Results — 4 failure(s), 20 flaky✅ 4004 passed · ❌ 4 failed · 🟡 20 flaky · ⏭️ 86 skipped
Genuine Failures (failed on all attempts)❌
|
Code Review ✅ ApprovedAdds supplementary logging to the PBI lineage process to improve debugging visibility. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
--------- Co-authored-by: Satender K <satendra.kumar@getcollate.io>
|


Describe your changes:
I worked on adding more logs on lineage process to debug
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
PowerbiSourceto trace lineage creation processes for dashboards, reports, and datamodels.# noqa: RUF010to various debug log statements to maintain linting compliance._fetch_report_from_workspacereturn type fromDatasettoPowerBIReport.This will update automatically on new commits.