plugins/rest: carry over all of *tls.Config#8476
Open
srenatus wants to merge 1 commit intoopen-policy-agent:mainfrom
Open
plugins/rest: carry over all of *tls.Config#8476srenatus wants to merge 1 commit intoopen-policy-agent:mainfrom
*tls.Config#8476srenatus wants to merge 1 commit intoopen-policy-agent:mainfrom
Conversation
- The tokenTLSConfig is cloned from DefaultTLSConfig(c) (which includes RootCAs) and then InsecureSkipVerify is set explicitly from c.AllowInsecureTLS, since DefaultTLSConfig only sets it when the service URL is https, but the token URL is always https regardless. - New test configures a service with tls.ca_cert pointing to the token server's CA cert, without allow_insecure_tls. This directly reproduces the bug report — before the fix, this would fail with x509: certificate signed by unknown authority. Also removes some duplication we had before. Fixes open-policy-agent#8473. Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
srenatus
force-pushed
the
sr/vypmmunrtsrx
branch
from
3127a71 to
24fd300
Compare
srenatus
changed the title
*tls.Config*tls.Config
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sspaink
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8473.