clarify species type extension#264
Conversation
|
Following discussion in #262 I replaced RFC 2119 terms (MUST, SHOULD NOT...) with bold text, but using lowercase. |
ax3l
left a comment
There was a problem hiding this comment.
Thank you already!
I marked a few typos and will do a thorough review soon!
DavidSagan
left a comment
There was a problem hiding this comment.
Thanks for the work done by everyone!
Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja>
|
If I read the openPMD validator correctly (do I?), currently only non-empty strings consisting of
|
|
I think that makes sense, if one uses the species type extension then one should actually specify a |
|
Sorry for the delay, in it goes! Great work! |
This PR clarifies the species type extension, adds a full definition using ABNF.
Technically it introduces breaking changes -- for details, please see below.
Issues: #256 #257 #258 #259 #260 #261
Description
other:is not allowed in lists, as to allow it the semicolon;would have to be forbidden from its content.item1;;item2), trailing separator optional.other:other:(without suffix) as well as trailing spaces -- even though they are allowed.In its entirety, this aims to clarify the current version of the standard.
Except for the treatment of
other:, all unambiguous parts have been left untouched.Valid examples:
Invalid examples:
other:··electron;;H;;UuxH2OAffected Components
EXT-SpeciesTypeLogic Changes
other:forbidden in listsWriter Changes
speciesTypesother:Existing writers are compatible, as long as they
speciesTypeReader Changes
Lists with one item must be considered single particle species.
As molecules and ions have been explicitly forbidden, reader implementations are encouraged to specify their additionally accepted syntax explicitly.
(Which they should do anyways).
openPMD-validator: https://github.com/openPMD/openPMD-validator/(I did not encounter any other mentions of
speciesTypein the related tools.)Data Converter
Not implemented, hence no changes necessary.