Skip to content

Implement support for dynamic buildrequires in 'osc build'#2151

Draft
dmach wants to merge 1 commit into
openSUSE:masterfrom
dmach:feat/osc-build-dynamic-buildrequires
Draft

Implement support for dynamic buildrequires in 'osc build'#2151
dmach wants to merge 1 commit into
openSUSE:masterfrom
dmach:feat/osc-build-dynamic-buildrequires

Conversation

@dmach

@dmach dmach commented May 20, 2026

Copy link
Copy Markdown
Contributor

Fixes: #1706

@dmach dmach requested review from DimStar77 and darix May 20, 2026 07:14
@codecov

codecov Bot commented May 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.80%. Comparing base (2ac8f0a) to head (14a0176).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
osc/build.py 0.00% 46 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
- Coverage   33.86%   33.80%   -0.06%     
==========================================
  Files         199      199              
  Lines       27144    27190      +46     
==========================================
  Hits         9191     9191              
- Misses      17953    17999      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darix

darix commented May 20, 2026

Copy link
Copy Markdown
Member

woohoo +1

@dmach dmach marked this pull request as draft May 21, 2026 08:48
@dmach

dmach commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

I got additional feedback and I should:

  • check the exit codes; we should use only 11
  • don't strip the versions in dependencies, use the deps as provided
  • store the generated BRs on disk (similarly to buildconfig); properly handle --clean
  • use /.build.packages/OTHER/_generated_buildreqs instead of parsing deps from nosrc.rpm
  • when e.g. iteration 6 fails, don't start over, use previously stored deps; but make sure that re-using the buildroot to build another package in a project works fine

@mlschroe

Copy link
Copy Markdown
Member

(I think build's exit code is 9, not 11)

@darix

darix commented May 21, 2026

Copy link
Copy Markdown
Member

it checks for 9 and 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

osc build needs to learn the 2-phase approach of OBS with %generate_buildrequires

3 participants