Skip to content

Make TestGitEditor more portable #2159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AMDmi3 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −6
Open

Make TestGitEditor more portable #2159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/test_git_editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,21 @@
from osc.gitea_api.common import get_editor_command


vim_executable = shutil.which("vim")
nano_executable = shutil.which("nano")


class TestGitEditor(unittest.TestCase):

def test_default(self):
with unittest.mock.patch.dict(os.environ, {"EDITOR": ""}):
c = get_editor_command("test")
self.assertEqual(c, ["/usr/bin/vim", "test"])
self.assertEqual(c, [vim_executable, "test"])

def test_custom(self):
with unittest.mock.patch.dict(os.environ, {"EDITOR": "nano"}):
c = get_editor_command("test")
self.assertEqual(c, ["/usr/bin/nano", "test"])
self.assertEqual(c, [nano_executable, "test"])

def test_custom_with_param(self):
with unittest.mock.patch.dict(os.environ, {"EDITOR": "/usr/bin/emacs -nv"}):
Expand All @@ -34,10 +38,10 @@ def test_custom_with_miltiword_params(self):
self.assertEqual(c, ["/usr/bin/mycmd", "-A", "my fancy parameter ", "test"])


if shutil.which("nano") != "/usr/bin/nano":
TestGitEditor = unittest.skip("nano is not /usr/bin/nano")(TestGitEditor)
elif shutil.which("vim") != "/usr/bin/vim":
TestGitEditor = unittest.skip("vim is not /usr/bin/vim")(TestGitEditor)
if nano_executable is None:
TestGitEditor = unittest.skip("nano executable missing")(TestGitEditor)
elif vim_executable is None:
TestGitEditor = unittest.skip("vim executable missing")(TestGitEditor)

if __name__ == "__main__":
unittest.main()
Loading