fix: delete device integrations after device deletion#872
Open
fix: delete device integrations after device deletion#872
Conversation
3 tasks
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
scheidtdav
reviewed
Apr 13, 2026
Comment on lines
+248
to
+253
| if (failedDeletions.length > 0) { | ||
| console.error('Failed to delete one or more integrations before device deletion', { | ||
| deviceID, | ||
| failedDeletions, | ||
| }) | ||
| } |
Member
There was a problem hiding this comment.
Won't this inevitably produce problems when we still delete the device but not the integration?
As long as we won't proactively monitor such logs, we would be producing dead integrations..
I am not sure whats the right way to go forward it, just want to discuss. Should be break the device deletion process here as well? That way we probably get to know about a problem faster?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Implementation
Checklist
devbranchAdditional Information