Fix conservative openai.yaml regeneration and validate agents config#346
Open
wsk-builds wants to merge 1 commit intoopenai:mainfrom
Open
Fix conservative openai.yaml regeneration and validate agents config#346wsk-builds wants to merge 1 commit intoopenai:mainfrom
wsk-builds wants to merge 1 commit intoopenai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_openai_yaml.pyupdateagents/openai.yamlconservatively instead of overwriting non-interface sectionsquick_validate.pyvalidateagents/openai.yamlsyntax and core structure in addition toSKILL.mdProblem
generate_openai_yaml.pycurrently rewrites the entireagents/openai.yamlfile from scratch. Re-running it can silently drop existing fields such asdependencies, icons, anddefault_prompt, even though those are documented as supported structure inreferences/openai_yaml.md.quick_validate.pyalso only validatesSKILL.mdfrontmatter today. A skill can contain an invalid or structurally brokenagents/openai.yamland still pass validation.Changes
Conservative regeneration
agents/openai.yamlbefore regeneratinginterface.display_nameandinterface.short_descriptionfieldsdependenciesValidation coverage
agents/openai.yamlvalidation toquick_validate.pyinterface/dependencies, and malformeddependencies.toolsinterfaceanddependencies.tools[]have string valuesRegression tests
dependenciesand interface metadata during regenerationagents/openai.yamlagents/openai.yamland failure on invalid YAMLValidation
python3 skills/.system/skill-creator/scripts/skill_creator_scripts_test.pypython3 skills/.system/skill-creator/scripts/quick_validate.py skills/.system/skill-creatorpython3 skills/.system/skill-creator/scripts/quick_validate.py skills/.system/openai-docs