Fix a bunch of eslint and type-checker complaints#1626
Open
Arnei wants to merge 2 commits into
Open
Conversation
Eslint exceptions in general should be avoided. If absolutely necessary, they should at least have an explaining comment accompanying them. This patch aims at achieving that. Arguably some of the eslint exceptions I left in could still be removed, but that would usually mean major programming effort. Of note is that this patch includes `dispatch` in useEffect dependency arrays, even if that useEffect hook should run only once on mount. We can do that because dispatch is stable, it's just that the lint rules can't know that. See also official redux docs: https://react-redux.js.org/api/hooks
This removes a bunch of // @ts-expect-errors by fixing the respective type issues.
Arnei
added
type:typing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #469.
Looks at all the comments that are disabling eslint or typescript and either addresses the underlying issue or adds an additional comment on why disabling the respective rule is actually okay in that case.
How to test this
Nothing specific to test here, the code review is probably a lot more important.