fix: hide pastebin and notes app menu entries on public pages#442
Open
dschmidt wants to merge 2 commits into
Open
fix: hide pastebin and notes app menu entries on public pages#442dschmidt wants to merge 2 commits into
dschmidt wants to merge 2 commits into
Conversation
The pastebin menu item was rendered into the app switcher even on public-link views where no user is logged in. Match the pattern used by web-app-draw-io and return an empty extension list when there is no user in the store. Fixes #413
Same as pastebin: the notes menu item was rendered into the app switcher even on public-link views where no user is logged in. Return an empty extension list when there is no user in the store. This does not affect opening .ocnb files via public links — that flow goes through appInfo.extensions with authContext: 'hybrid', which is independent of the menu item.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The pastebin and notes app-switcher entries appeared on public-link views where no user is logged in. Both items link to user-space routes that anonymous visitors cannot use. Guard
menuItemswithuserStore.user, matching the existingweb-app-draw-iopattern.Opening
.pastebinfolders or.ocnbfiles via public links is unaffected; that flow usesappInfo.extensionswithauthContext: 'hybrid', independent of the menu item.Related Issue
How Has This Been Tested?
vue-tsc --noEmitclean for both packages.pastebin/.ocnbvia public link should still openTypes of changes