RT-8 : Fix validation for breakout port check#5558
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the robustness of the breakout port validation process in the singleton test suite. By replacing the existing PMD consistency check with a more detailed verification of hardware-port mappings and component configurations, the changes ensure that breakout modes are correctly applied and reflected in the device state. Additionally, a sleep interval was added to account for configuration propagation time, reducing potential flakiness in test execution. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5558 / 027f9aeVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the breakout test suite by renaming verifyConsistentPMD to verifyInterfaceHardwarePortAndBreakoutConfig and adding validation for breakout configurations on 400G ports. The reviewer's feedback highlights three key improvement opportunities: querying the operational state (.State()) instead of the configuration (.Config()) to ensure the breakout mode is applied, using gnmi.Lookup instead of testt.CaptureFatal to safely check for component names, and reusing the pre-fetched interfaces slice inside the loop to avoid redundant and inefficient gNMI GET requests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
…gleton_with_breakouts_test.go Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…rofiles into RT-8_3 # Conflicts: # feature/interface/singleton/tests/singleton_with_breakouts/singleton_with_breakouts_test.go
Changes to validate the breakout config for base test cases & reboot test cases