Skip to content

RT-8 : Fix validation for breakout port check#5558

Open
priyaranjannanda wants to merge 7 commits into
openconfig:mainfrom
priyaranjannanda:RT-8_3
Open

RT-8 : Fix validation for breakout port check#5558
priyaranjannanda wants to merge 7 commits into
openconfig:mainfrom
priyaranjannanda:RT-8_3

Conversation

@priyaranjannanda

Copy link
Copy Markdown
Contributor

Changes to validate the breakout config for base test cases & reboot test cases

@priyaranjannanda priyaranjannanda requested a review from a team as a code owner June 11, 2026 12:47
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the breakout port validation process in the singleton test suite. By replacing the existing PMD consistency check with a more detailed verification of hardware-port mappings and component configurations, the changes ensure that breakout modes are correctly applied and reflected in the device state. Additionally, a sleep interval was added to account for configuration propagation time, reducing potential flakiness in test execution.

Highlights

  • Enhanced Validation Logic: Replaced the basic PMD verification with a comprehensive check that validates both hardware-port references and breakout configuration settings.
  • Breakout Configuration Verification: Added specific logic to inspect breakout mode, group settings, number of breakouts, and speed for 400GBASE-DR4 ports.
  • Test Stability: Introduced a 20-second delay after configuration to ensure breakout settings are fully applied before state verification begins.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Jun 11, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5558 / 027f9ae

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-8: Singleton with breakouts
Cisco 8000E status
RT-8: Singleton with breakouts
Cisco XRd status
RT-8: Singleton with breakouts
Juniper ncPTX status
RT-8: Singleton with breakouts
Nokia SR Linux status
RT-8: Singleton with breakouts
Openconfig Lemming status
RT-8: Singleton with breakouts

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-8: Singleton with breakouts
Cisco 8808 status
RT-8: Singleton with breakouts
Juniper PTX10008 status
RT-8: Singleton with breakouts
Nokia 7250 IXR-10e status
RT-8: Singleton with breakouts

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the breakout test suite by renaming verifyConsistentPMD to verifyInterfaceHardwarePortAndBreakoutConfig and adding validation for breakout configurations on 400G ports. The reviewer's feedback highlights three key improvement opportunities: querying the operational state (.State()) instead of the configuration (.Config()) to ensure the breakout mode is applied, using gnmi.Lookup instead of testt.CaptureFatal to safely check for component names, and reusing the pre-fetched interfaces slice inside the loop to avoid redundant and inefficient gNMI GET requests.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@priyaranjannanda priyaranjannanda changed the title Fix validation for breakout port check RT-8 : Fix validation for breakout port check Jun 11, 2026
priyaranjannanda and others added 6 commits June 17, 2026 11:49
…gleton_with_breakouts_test.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…rofiles into RT-8_3

# Conflicts:
#	feature/interface/singleton/tests/singleton_with_breakouts/singleton_with_breakouts_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants