New deviation for Cisco to decouple usage from existing deviation interface_ref_interface_id_format#5560
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a specialized deviation to handle interface ID formatting requirements specifically for policy-forwarding. By decoupling this from the generic 'interface_ref_interface_id_format' deviation, the change allows for more granular control over device-specific behavior without impacting other vendors or existing test configurations. The update ensures that Cisco TE/PBR tests can correctly format interface keys as required by the platform. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new deviation interface_id_format_required_for_policy_forwarding and its accessor InterfaceIDFormatRequiredForPolicyForwarding to support devices requiring policy-forwarding interface keys to use the interface name with a subinterface index. This deviation is integrated across various test files and metadata configurations. Feedback on the changes highlights that the new deviation accessor function in internal/deviations/deviations.go is missing a comment containing a URL link to an issue tracker tracking its removal, which violates the repository's deviation guidelines.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
# Conflicts: # proto/metadata.proto # proto/metadata_go_proto/metadata.pb.go
…sco_pbf_new_deviation
|
Update: new deviation already added in other TE PRs by me and they are now merged. This PR is only for migrating tests from older interface_ref_interface_id_format to new interface_id_format_required_for_policy_forwarding required for PBR/PBF Cisco usecases. |
2 participants
Goal:
Add one new narrow deviation for policy-forwarding interface keys and migrate Cisco TE/PBR tests that currently misuse interface_ref_interface_id_format for that purpose. Leave the existing interface_ref_interface_id_format name and all other vendors' usages intact.
Changes designed to be backward compatible.
Context for this change: https://partnerissuetracker.corp.google.com/issues/504497643#comment9
Note:
Will add similar changes changes for encap_frr, encap_frr_with_reencap_vrf_test and vrf_policy_driven_te in the existing open PR