Skip to content

Add failover tests for image transfer, container start, and volume cr…#5565

Open
chitadi wants to merge 5 commits into
mainfrom
chitadi-patch-6
Open

Add failover tests for image transfer, container start, and volume cr…#5565
chitadi wants to merge 5 commits into
mainfrom
chitadi-patch-6

Conversation

@chitadi

@chitadi chitadi commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

…eation

The test numbers have been adjusted according to PR - 5562

…eation

The test numbers have been adjusted according to PR - 5562
@chitadi chitadi requested a review from a team as a code owner June 12, 2026 08:38
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a suite of failover tests designed to validate the system's resilience during supervisor switchovers. By simulating interruptions in critical container lifecycle operations, these tests ensure that the system handles unexpected state transitions gracefully and maintains consistency.

Highlights

  • New Failover Tests: Added three new test cases (CNTR-3.7, CNTR-3.8, CNTR-3.9) to verify system behavior during supervisor switchover events.
  • Test Coverage: Implemented tests for interrupting image transfers, container startup processes, and volume creation to ensure robust handling of failover scenarios.
  • Test Infrastructure: Integrated cleanup routines and telemetry-based synchronization to ensure reliable test execution and state verification across switchovers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot

OpenConfigBot commented Jun 12, 2026

Copy link
Copy Markdown

Pull Request Functional Test Report for #5565 / 79303a5

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
CNTR-3: Container Supervisor Failover
fb7b32ef Log
Cisco 8000E status
CNTR-3: Container Supervisor Failover
6f28aa43 Log
Cisco XRd status
CNTR-3: Container Supervisor Failover
1033177e Log
Juniper ncPTX status
CNTR-3: Container Supervisor Failover
fc0c286f Log
Nokia SR Linux status
CNTR-3: Container Supervisor Failover
b0991f19 Log
Openconfig Lemming status
CNTR-3: Container Supervisor Failover
089bb60d Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
CNTR-3: Container Supervisor Failover
Cisco 8808 status
CNTR-3: Container Supervisor Failover
Juniper PTX10008 status
CNTR-3: Container Supervisor Failover
Nokia 7250 IXR-10e status
CNTR-3: Container Supervisor Failover

Help

More changes made according to numbering proposed in PR - 5562
gemini-code-assist[bot]

This comment was marked as outdated.

@chitadi

This comment was marked as outdated.

gemini-code-assist[bot]

This comment was marked as outdated.

@chitadi

chitadi commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces three new failover integration tests (TestInterruptImageTransferFailover, TestInterruptContainerStartFailover, and TestInterruptVolumeCreationFailover) and updates existing test mappings to their correct test case IDs. The feedback points out that the corresponding README.md needs to be updated to reflect these new test numbers and document the new test cases, ensuring compliance with the repository style guide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants