Add tests for container placement with LC_PRIMARY, LC_BACKUP, and LC_ALL

[chitadi]

Subtest numbering according to PR - 5562

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces automated testing for container placement policies, specifically covering LC_PRIMARY, LC_BACKUP, and LC_ALL configurations. The changes ensure that containers are correctly deployed and persist or migrate as expected during route processor switchovers, validating the container orchestration logic on the device.

Highlights

• New Test Implementation: Added three new test cases: TestContainerPlacementLCPRIMARY, TestContainerPlacementLCBACKUP, and TestContainerPlacementLCALL to validate container placement behavior across route processors.
• Placement Verification: Implemented verification logic that performs switchovers to confirm containers are correctly placed and running on the expected route processors based on the specified location configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5567 / de7c0d0

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		CNTR-3: Container Supervisor Failover	01987a3f	Log
Cisco 8000E		CNTR-3: Container Supervisor Failover	21a5496a	Log
Cisco XRd		CNTR-3: Container Supervisor Failover	f105b133	Log
Juniper ncPTX		CNTR-3: Container Supervisor Failover	97d6d060	Log
Nokia SR Linux		CNTR-3: Container Supervisor Failover	99d032a7	Log
Openconfig Lemming		CNTR-3: Container Supervisor Failover	c2242afe	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		CNTR-3: Container Supervisor Failover
Cisco 8808		CNTR-3: Container Supervisor Failover
Juniper PTX10008		CNTR-3: Container Supervisor Failover
Nokia 7250 IXR-10e		CNTR-3: Container Supervisor Failover

Help

[gemini-code-assist]

Code Review

This pull request introduces three new integration tests (TestContainerPlacementLCPRIMARY, TestContainerPlacementLCBACKUP, and TestContainerPlacementLCALL) to verify container placement behavior during supervisor switchovers. However, there are critical logic errors in the post-switchover assertions for both the LCPRIMARY and LCBACKUP tests. Specifically, TestContainerPlacementLCPRIMARY incorrectly asserts that the container does not exist on the new primary supervisor, and TestContainerPlacementLCBACKUP incorrectly asserts that the container is running on the new primary supervisor instead of the new standby supervisor.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[chitadi]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces three new container placement failover tests: TestContainerPlacementLCPRIMARY, TestContainerPlacementLCBACKUP, and TestContainerPlacementLCALL. The feedback highlights swapped log messages in the primary and backup placement tests, as well as a redundant wait call in the LC_ALL placement test that could introduce test flakiness.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.