Skip to content

Add more coverage to address gaps #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ram-mac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add more coverage to address gaps #5568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 81 additions & 1 deletion feature/interface/otg_tests/telemetry_interface_packet_counters_test/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,18 @@ following features:
* /interfaces/interface[name='port']/state/counters/out-pkts
* /interfaces/interface[name='port']/subinterfaces/subinterface[index='index-id']/ipv4/state/counters/in-pkts
* /interfaces/interface[name='port']/subinterfaces/subinterface[index='index-id']/ipv6/state/counters/in-pkts


* **Dynamic Interface Counter Freshness Under Traffic (b/440241619)**

Verify that the OpenConfig egress counters dynamically update in real-time under active traffic (including encapsulated traffic) and reflect rate changes within a strict latency window.

* Config Push: Apply a standard WBB interface configuration, enabling both basic interface counters and IP-in-IP tunnel encapsulation.
* Initial Flow (Low Rate): Inject traffic from the ATE at R1 = 10,000 pps.
* Verify Telemetry: Query `/interfaces/interface/subinterfaces/subinterface/ipv4/state/counters/out-pkts` via gNMI STREAM and assert that the rate matches 10,000 pps.
* Step-Up Flow (High Rate): Abruptly increase the traffic injection rate to R2 = 100,000 pps.
* Freshness & Latency Assertion:
* Begin a timer at the moment of the rate change.
* Verify that the streamed telemetry updates successfully reflect the new rate of 100,000 pps within <= 15 seconds.

* Subinterfaces counters:

Expand Down Expand Up @@ -71,6 +82,74 @@ following features:
* TODO: /interfaces/interface/state/cpu
* TODO: /interfaces/interface/state/management

#### Canonical OC

```json
{
"interfaces": {
"interface": [
{
"config": {
"description": "Input interface port1",
"enabled": true,
"name": "port1",
"type": "ethernetCsmacd"
},
"name": "port1",
"rates": {
"config": {
"load-interval": 30
}
},
"subinterfaces": {
"subinterface": [
{
"config": {
"enabled": true,
"index": 0
},
"index": 0,
"ipv4": {
"addresses": {
"address": [
{
"config": {
"ip": "198.51.100.0",
"prefix-length": 31
},
"ip": "198.51.100.0"
Comment on lines +117 to +120

@gemini-code-assist gemini-code-assist Bot Jun 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While 198.51.100.0 with a /31 prefix is technically valid under RFC 3021, some vendor platforms or strict parsers may reject .0 as a network address. To ensure maximum compatibility across all target platforms, it is recommended to use a non-zero host IP address such as 198.51.100.1.

Suggested change
"ip": "198.51.100.0",
"prefix-length": 31
},
"ip": "198.51.100.0"
"ip": "198.51.100.1",
"prefix-length": 31
},
"ip": "198.51.100.1"

}
]
},
"config": {
"enabled": true
}
},
"ipv6": {
"addresses": {
"address": [
{
"config": {
"ip": "2001:db8::1",
"prefix-length": 126
},
"ip": "2001:db8::1"
}
]
},
"config": {
"enabled": true
}
}
}
]
}
}
]
}
}
```

## Testbed type

* [`featureprofiles/topologies/atedut_2.testbed`](https://github.com/openconfig/featureprofiles/blob/main/topologies/atedut_2.testbed)
Expand Down Expand Up @@ -150,3 +229,4 @@ rpcs:
## Minimum DUT platform requirement
* FFF - fixed form factor


Loading