Skip to content

PF-1.6: updated default instance type#5590

Open
sudhirakondi wants to merge 5 commits into
openconfig:mainfrom
sudhirakondi:avr-pf-1.6
Open

PF-1.6: updated default instance type#5590
sudhirakondi wants to merge 5 commits into
openconfig:mainfrom
sudhirakondi:avr-pf-1.6

Conversation

@sudhirakondi

Copy link
Copy Markdown
Contributor

Code modificiton to set default instance type for the network-instance.

@sudhirakondi sudhirakondi requested a review from a team as a code owner June 18, 2026 07:55
@OpenConfigBot

OpenConfigBot commented Jun 18, 2026

Copy link
Copy Markdown

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the network instance configuration flow within the policy-based VRF selection test. By reordering the calls to update the DUT with network instance configurations, the changes ensure that the environment is correctly initialized before BGP services are enabled, improving the reliability of the test setup.

Highlights

  • Network Instance Configuration: Updated the configuration sequence for network instances to ensure they are applied to the DUT before enabling BGP.
  • Code Cleanup: Removed redundant network instance update calls from the later stages of the configuration function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request rearranges the configuration sequence for network instances and BGP in the VRF selection test. However, moving the UpdateNetworkInstanceOnDut calls to before the BGP neighbor configuration prevents the in-memory BGP neighbor configurations from being pushed to the DUT. To resolve this, the UpdateNetworkInstanceOnDut calls must also be executed after the BGP neighbors are configured.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

sudhirakondi and others added 4 commits June 18, 2026 13:32
…n/policy_based_vrf_selection_for_ipv4_ipv6_test.go

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants