PF-1.24 : update policy to allow icmpv6 ND packets

[sudhirakondi]

No description provided.

[OpenConfigBot]

Pull Request Functional Test Report for #5592 / 2984a7e

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PF-1.24: Add and remove interface bound to PBF
Cisco 8000E		PF-1.24: Add and remove interface bound to PBF
Cisco XRd		PF-1.24: Add and remove interface bound to PBF
Juniper ncPTX		PF-1.24: Add and remove interface bound to PBF
Nokia SR Linux		PF-1.24: Add and remove interface bound to PBF
Openconfig Lemming		PF-1.24: Add and remove interface bound to PBF

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PF-1.24: Add and remove interface bound to PBF
Cisco 8808		PF-1.24: Add and remove interface bound to PBF
Juniper PTX10008		PF-1.24: Add and remove interface bound to PBF
Nokia 7250 IXR-10e		PF-1.24: Add and remove interface bound to PBF

Help

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the policy forwarding configuration in the OTG tests to properly handle ICMPv6 Neighbor Discovery traffic. It also cleans up network address constants and enhances the test setup sequence to ensure ARP resolution is completed before traffic flow validation.

Highlights

• Policy Update: Updated the VRF selection policy to include a rule for ICMPv6 Neighbor Discovery packets (ff02::/16).
• Test Configuration: Refactored network constants and static route configurations to accommodate updated test scenarios.
• Test Reliability: Added explicit logging and waiting for ARP resolution in the ATE configuration process to improve test stability.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the test to use RFC-compliant IP address ranges for IPv4 and IPv6, configures static routes and OTG flows accordingly, and modifies the policy forwarding rules. The review feedback points out that rule r20 matches IPv6 link-local multicast traffic but lacks an action, and suggests explicitly setting the action's network instance to the default network instance.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The policy forwarding rule r20 matches IPv6 link-local multicast traffic (ff02::/16) but does not configure any action. A policy forwarding rule without an action is incomplete and will likely fail configuration validation on the DUT. To ensure these packets are processed correctly by the default network instance, explicitly set the action's network instance to the default network instance.

Suggested change

	r20 := p6.GetOrCreateRule(10)
	r20.GetOrCreateIpv6().SetSourceAddress(atePort2.IPv6 + "/128")
	r20.GetOrCreateAction().NetworkInstance = ygot.String(vrf100Name)
	r20.GetOrCreateIpv6().SetDestinationAddress("ff02::/16")
	r20 := p6.GetOrCreateRule(10)
	r20.GetOrCreateIpv6().SetDestinationAddress("ff02::/16")
	r20.GetOrCreateAction().NetworkInstance = ygot.String(deviations.DefaultNetworkInstance(dut))